Skip to content

fix(assetlibrary): properly quote escaped characters in cloudformation #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2024
Merged

fix(assetlibrary): properly quote escaped characters in cloudformation #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4814ce
fix(assetlibrary): properly quote escaped characters in cloudformation
aaronatbissell Jan 24, 2024
fe312fd
chore: changelogs
aaronatbissell Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...anges/@awssolutions/cdf-assetlibrary/fix_db_instance_type_parameter_2024-01-24-12-21.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@awssolutions/cdf-assetlibrary",
"comment": "properly quote escaped regex pattern in cloudformation",
"type": "none"
}
],
"packageName": "@awssolutions/cdf-assetlibrary"
}
4 changes: 2 additions & 2 deletions source/packages/services/assetlibrary/infrastructure/cfn-neptune.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ Parameters:
Type: List<AWS::EC2::Subnet::Id>
DbInstanceType:
Description: >
Neptune DB instance type. The list of available instance types for your region can be found here:
Neptune DB instance type. The list of available instance types for your region can be found here:
https://aws.amazon.com/neptune/pricing/
Type: String
AllowedPattern: '^db\\.[tr]\\d+[a-z0-9]*\\.[a-z0-9]*$'
AllowedPattern: "^db\\.[tr]\\d+[a-z0-9]*\\.[a-z0-9]*$"
ConstraintDescription: Must be a valid Neptune instance type.
CreateDBReplicaInstance:
Description: Create a read replica for MultiAZ?
Expand Down