Skip to content

Conversation

@ianbotsf
Copy link
Contributor

@ianbotsf ianbotsf commented Sep 23, 2022

Issue #, if available:

(none)

Description of changes:

Update and clarify the contributing guidelines to more explicitly detail:

  • Expected format for changelog entries

Similar to smithy-kotlin#706 except without the commit guidelines because those don't exist in this guide also add new commit guidelines.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ianbotsf ianbotsf requested a review from a team as a code owner September 23, 2022 20:21
@ianbotsf
Copy link
Contributor Author

Actually, we should probably add commit instructions here to match the other repos.

Copy link
Member

@lauzadis lauzadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call on adding the commit guidelines to this repository too

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ianbotsf ianbotsf merged commit 97af857 into main Sep 23, 2022
@ianbotsf ianbotsf deleted the chore-contributing-clarifications branch September 23, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants