ci: run spotless on every pull request - #591
Merged
Merged
Conversation
wangyb-A
marked this pull request as ready for review
August 4, 2026 21:57
wangyb-A
temporarily deployed
to
ai-pr-review-runtime
August 4, 2026 21:57 — with
GitHub Actions
Inactive
wangyb-A
temporarily deployed
to
ai-pr-review-runtime
August 4, 2026 21:57 — with
GitHub Actions
Inactive
ayushiahjolia
approved these changes
Aug 4, 2026
Claude AI reviewNo actionable findings. The PR contains only:
Residual test risk: minimal. The Java edits are formatting-only and don't alter or add test logic. The workflow change is not exercised by unit tests, but its YAML is straightforward and its effect (running Spotless more broadly) can only surface pre-existing formatting violations, not mask regressions. Reviewed commit |
Codex AI reviewNo actionable findings. Residual risk: Per review constraints, Maven/Spotless and the updated GitHub Actions triggers were not executed; validation remains dependent on CI. Reviewed commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
spotless-checkhad apathsfilter covering onlysdk/**,sdk-testing/**,sdk-integration-tests/**, andexamples/**, butmvn spotless:check --file pom.xmlvalidates every Maven module. Modules missing from that filter —otel-plugin,conformance-tests,coverage-report— can merge unformatted code without the job ever running, and that code then fails the check on unrelated pull requests.This has already happened twice:
14ad139otel-plugin/,examples/examples/**)acfa484otel-plugin/only#583has nospotless-checkentry in its check-runs at all. An earlier instance underconformance-tests/**was fixed by #586.Changes
pathsfilter so the job runs on every PR targetingmainpushonmainso drift is caught if anything else bypasses the gateworkflow_dispatchfor manual runsotel-plugintest files that are unformatted onmaintodayThe Java changes are formatting-only: with all whitespace stripped, both files are byte-identical to
main(Palantir split long constructor argument lists across lines).Validation
mvn -B -q spotless:check --file pom.xml— passes (fails onmaintoday)mvn -pl otel-plugin test— 145 passedpull_request,push,workflow_dispatchTradeoff
Removing the filter means every PR runs this job, including docs-only changes. The alternative — listing all seven modules — stays targeted but silently rots the next time a module is added, which is the root cause here.