fix(testing): honor history reverse order - #595
Merged
Conversation
mahayash315
force-pushed
the
agent/fix-history-reverse-order
branch
from
July 28, 2026 23:56
bca85ac to
25f9b48
Compare
mahayash315
requested a deployment
to
ai-pr-review
July 28, 2026 23:56 — with
GitHub Actions
Waiting
Contributor
|
thank you so much @mahayash315, great contribution, welcome to dex! Verified the wire contract against the public Lambda API model: ReverseOrder querystring name, lowercase true/false serialization from boto3, and absent-defaults-to-false all match the service exactly.
just waiting for CI to clear. |
yaythomas
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReverseOrderquery parameter in the testing WebServerget_execution_historyfalse, andtruevalues with a regression testRoot cause
The WebServer handler hard-coded
reverse_order=False, even though the executor already supports reverse-order history and pagination.Testing
hatch run dev-testing:test(1,365 passed)hatch run dev-testing:typecheckhatch fmt --checkFixes #594