Skip to content

fix(testing): honor history reverse order - #595

Merged
yaythomas merged 1 commit into
aws:mainfrom
mahayash315:agent/fix-history-reverse-order
Jul 29, 2026
Merged

fix(testing): honor history reverse order#595
yaythomas merged 1 commit into
aws:mainfrom
mahayash315:agent/fix-history-reverse-order

Conversation

@mahayash315

Copy link
Copy Markdown
Contributor

Summary

  • parse the ReverseOrder query parameter in the testing WebServer
  • forward the parsed value to get_execution_history
  • cover omitted, false, and true values with a regression test

Root cause

The WebServer handler hard-coded reverse_order=False, even though the executor already supports reverse-order history and pagination.

Testing

  • hatch run dev-testing:test (1,365 passed)
  • hatch run dev-testing:typecheck
  • hatch fmt --check
  • focused history-handler tests (8 passed)

Fixes #594

@mahayash315
mahayash315 marked this pull request as ready for review July 28, 2026 22:37
@mahayash315
mahayash315 force-pushed the agent/fix-history-reverse-order branch from bca85ac to 25f9b48 Compare July 28, 2026 23:56
@yaythomas

yaythomas commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

thank you so much @mahayash315, great contribution, welcome to dex!

Verified the wire contract against the public Lambda API model: ReverseOrder querystring name, lowercase true/false serialization from boto3, and absent-defaults-to-false all match the service exactly.

:shipit:

just waiting for CI to clear.

@yaythomas
yaythomas merged commit 37f414c into aws:main Jul 29, 2026
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Testing WebServer ignores ReverseOrder in GetDurableExecutionHistory

2 participants