feat: add support for ruby 4.0#855
Conversation
|
The issues with the CI are unrelated to any builders changes, and instead seem to be an issue with |
| python: | ||
| - "3.13" | ||
| ruby: | ||
| - "3.2" |
There was a problem hiding this comment.
create for ruby3.2 is actually supposed to be deprecated April 30, can we remove this?
There was a problem hiding this comment.
Based on what I see here function create is blocked 2026-08-31 and function update is blocked on 2026-09-30. My understanding is we usually don't remove runtimes until their update is blocked.
| ruby-version: "3.2" | ||
| ruby-version: ${{ matrix.ruby }} | ||
| - run: make init | ||
| - run: pytest -vv tests/integration/workflows/ruby_bundler |
There was a problem hiding this comment.
It's interesting that we use every these two versions of ruby (3.2, 4.0) to check that lambda-builders can build every version of ruby (from the test_ruby.py file).
One would think that we just need to build each version with the same version, but this is a more complete test (assuming that the test is real and it's actually building for each of the different ruby versions instead of just using the ruby from the environment and ignoring the runtime passed as a parameter.. in that case, we would be running the same test 4 times... so hopefully this all works how it's supposed to, and we have a very good test)
There was a problem hiding this comment.
I don't remember too well, but I think I had previously considered this issue when working on #808. I think you might be right (unfortunately) that we're running tests for functions with runtimes that are supposedly 3.4 or 3.6, but it's just in an environment that doesn't even have that version. I think that's non-blocking for this PR, but probably requires some more testing.
3 participants
Description of changes
Adds basic support and testing for Ruby 4.0. This is mostly just adding it to our supported runtime list and testing that it is successful.
Description of how you validated changes
make prpassed, seeing if the CI passes.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.