Skip to content

Amazon.Lambda.Core is not deterministic #2181

@martincostello

Description

@martincostello

Describe the bug

Viewing Amazon.Lambda.Core 2.8.0 in NuGet Package Explorer shows various warnings about the build of the package with respect to Source Link and determinism:

Image

The NuGet packages should be built with ContinuousIntegrationBuild=true and Deterministic=true to resolve this.

.NET global tools such as dotnet-validate and meziantou.framework.nugetpackagevalidation.tool can be used to verify this.

For Amazon.Lambda.Core at least, this doesn't appear to be a regression and these have never been enabled.

Regression Issue

  • Select this option if this issue appears to be a regression.

Expected Behavior

Packages should be deterministic, e.g. OpenTelemetry.Instrumentation.AWSLambda@1.13.0:

Image

Current Behavior

NuGet package is not deterministic:

Image

Reproduction Steps

View the NuGet package in NuGet Package Explorer.

Possible Solution

Set ContinuousIntegrationBuild=true and Deterministic=true MSBuild properties when building the NuGet packages for publishing to NuGet.org.

Additional Information/Context

No response

AWS .NET SDK and/or Package version used

Amazon.Lambda.Core 2.8.0

Targeted .NET Platform

All

Operating System and version

All

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugThis issue is a bug.needs-triageThis issue or PR still needs to be triaged.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions