Fix integ tests to make sure IAM role is cleaned up after test run#2275
Merged
Fix integ tests to make sure IAM role is cleaned up after test run#2275
Conversation
normj
added
the
Release Not Needed
There was a problem hiding this comment.
Pull request overview
This PR fixes IAM role cleanup in integration tests by detaching managed policies before deleting the role. The issue was that orphaned IAM roles were accumulating in the CI account because role deletion was failing when policies were still attached.
Changes:
- Added code to list and detach all managed policies from the IAM role before attempting deletion
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
....RuntimeSupport.Tests/Amazon.Lambda.RuntimeSupport.IntegrationTests/BaseCustomRuntimeTest.cs
Outdated
Show resolved
Hide resolved
....RuntimeSupport.Tests/Amazon.Lambda.RuntimeSupport.IntegrationTests/BaseCustomRuntimeTest.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Removed unnecessary exception handling for role deletion.
Removed comment about detaching managed policies.
dscpinheiro
approved these changes
Feb 5, 2026
GarrettBeatty
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Noticed our CI account was failing tests because we had too many orphan IAM roles being left around from previous test runs. I tracked down where the role was being created and updated the delete code which was was failing because we need to be sure to remove attach policies first.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.