Skip to content

treat warnings as errors #2329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GarrettBeatty merged 2 commits into from
Apr 13, 2026
Merged

treat warnings as errors #2329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
056f404
treat warnings as errors
GarrettBeatty Apr 13, 2026
d9f9a05
Change file
GarrettBeatty Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .autover/changes/7d00dacc-cece-4fcf-903b-f84b894eaf9e.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"Projects": [
{
"Name": "Amazon.Lambda.Annotations",
"Type": "Patch",
"ChangelogMessages": [
"treat warnings as errors and fix unshipped.md"
]
}
]
}
1 change: 1 addition & 0 deletions ...mazon.Lambda.Annotations.SourceGenerator/Amazon.Lambda.Annotations.SourceGenerator.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
<IncludeBuildOutput>false</IncludeBuildOutput>

<Version>1.11.0</Version>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>

<!-- Delay setting the package id till after resolving dependencies to avoid ambigious errors. -->
Expand Down
1 change: 1 addition & 0 deletions ...on.Lambda.Annotations.SourceGenerator/Diagnostics/AnalyzerReleases.Unshipped.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,4 @@ AWSLambda0132 | AWSLambdaCSharpGenerator | Error | Invalid ALBApiAttribute
AWSLambda0133 | AWSLambdaCSharpGenerator | Error | ALB Listener Reference Not Found
AWSLambda0134 | AWSLambdaCSharpGenerator | Error | FromRoute not supported on ALB functions
AWSLambda0135 | AWSLambdaCSharpGenerator | Error | Unmapped parameter on ALB function
AWSLambda0136 | AWSLambdaCSharpGenerator | Error | Invalid S3EventAttribute
8 changes: 4 additions & 4 deletions Libraries/src/Amazon.Lambda.Annotations/APIGateway/HttpApiAuthorizerAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ namespace Amazon.Lambda.Annotations.APIGateway
/// </summary>
/// <remarks>
/// This attribute must be used in conjunction with the <see cref="LambdaFunctionAttribute"/>.
/// The authorizer function should return <see cref="Amazon.Lambda.APIGatewayEvents.APIGatewayCustomAuthorizerV2SimpleResponse"/>
/// when <see cref="EnableSimpleResponses"/> is true, or <see cref="Amazon.Lambda.APIGatewayEvents.APIGatewayCustomAuthorizerV2IamResponse"/>
/// The authorizer function should return <c>APIGatewayCustomAuthorizerV2SimpleResponse</c>
/// when <see cref="EnableSimpleResponses"/> is true, or <c>APIGatewayCustomAuthorizerV2IamResponse</c>
/// when <see cref="EnableSimpleResponses"/> is false.
/// </remarks>
/// <example>
Expand Down Expand Up @@ -45,8 +45,8 @@ public class HttpApiAuthorizerAttribute : Attribute
/// Defaults to true for simpler implementation.
/// </summary>
/// <remarks>
/// When true, the authorizer should return <see cref="Amazon.Lambda.APIGatewayEvents.APIGatewayCustomAuthorizerV2SimpleResponse"/>.
/// When false, the authorizer should return <see cref="Amazon.Lambda.APIGatewayEvents.APIGatewayCustomAuthorizerV2IamResponse"/>.
/// When true, the authorizer should return <c>APIGatewayCustomAuthorizerV2SimpleResponse</c>.
/// When false, the authorizer should return <c>APIGatewayCustomAuthorizerV2IamResponse</c>.
/// </remarks>
public bool EnableSimpleResponses { get; set; } = true;

Expand Down
2 changes: 1 addition & 1 deletion Libraries/src/Amazon.Lambda.Annotations/APIGateway/RestApiAuthorizerAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public enum RestApiAuthorizerType
/// </summary>
/// <remarks>
/// This attribute must be used in conjunction with the <see cref="LambdaFunctionAttribute"/>.
/// The authorizer function should return <see cref="Amazon.Lambda.APIGatewayEvents.APIGatewayCustomAuthorizerResponse"/>.
/// The authorizer function should return <c>APIGatewayCustomAuthorizerResponse</c>.
/// </remarks>
/// <example>
/// <code>
Expand Down
1 change: 1 addition & 0 deletions Libraries/src/Amazon.Lambda.Annotations/Amazon.Lambda.Annotations.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
<SignAssembly>true</SignAssembly>

<Version>1.11.0</Version>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>

<PropertyGroup Condition="'$(TargetFramework)' == 'net8.0'">
Expand Down
Loading