Add Amazon.Lambda.DurableExecution project scaffolding#2359
Open
GarrettBeatty wants to merge 1 commit into
Open
Add Amazon.Lambda.DurableExecution project scaffolding#2359GarrettBeatty wants to merge 1 commit into
GarrettBeatty wants to merge 1 commit into
Conversation
GarrettBeatty
requested review from
normj and
philasmar
and removed request for
a team
GarrettBeatty
force-pushed
the
GarrettBeatty/stack/1
branch
from
9d78744 to
075b5e6
Compare
GarrettBeatty
force-pushed
the
GarrettBeatty/stack/1
branch
2 times, most recently
from
994f721 to
040265a
Compare
Merged
GarrettBeatty
changed the base branch from
feature/durablefunction
to
GarrettBeatty/stack/3
GarrettBeatty
force-pushed
the
GarrettBeatty/stack/1
branch
from
040265a to
fa704e7
Compare
GarrettBeatty
added
the
Release Not Needed
GarrettBeatty
force-pushed
the
GarrettBeatty/stack/1
branch
from
fa704e7 to
a90329b
Compare
GarrettBeatty
commented
May 12, 2026
| <Exec Command="dotnet test -c $(Configuration)" WorkingDirectory="..\Libraries\test\SnapshotRestore.Registry.Tests"/> | ||
| <Exec Command="dotnet test -c $(Configuration)" WorkingDirectory="..\Libraries\test\Amazon.Lambda.RuntimeSupport.Tests\Amazon.Lambda.RuntimeSupport.UnitTests"/> | ||
| <Exec Command="dotnet test -c $(Configuration)" WorkingDirectory="..\Libraries\test\Amazon.Lambda.Annotations.SourceGenerators.Tests"/> | ||
| <Exec Command="dotnet test -c $(Configuration)" WorkingDirectory="..\Libraries\test\Amazon.Lambda.DurableExecution.Tests"/> |
Collaborator
Author
There was a problem hiding this comment.
not sure if this is needed here or what this target is actually for and why it doesnt include other unit test projects? there is already a run-tests which runs everything
GarrettBeatty
commented
May 12, 2026
| "Path": "Libraries/src/Amazon.Lambda.Core/Amazon.Lambda.Core.csproj" | ||
| }, | ||
| { | ||
| "Name": "Amazon.Lambda.DurableExecution", |
Collaborator
Author
There was a problem hiding this comment.
ill create an actual change file at the very end once we are ready to release
GarrettBeatty
commented
May 12, 2026
| @@ -0,0 +1,5 @@ | |||
| namespace Amazon.Lambda.DurableExecution; | |||
|
|
|||
| internal static class AssemblyMarker | |||
Collaborator
Author
There was a problem hiding this comment.
file is placeholder for scaffolding. will be removed in next pr
GarrettBeatty
commented
May 12, 2026
|
|
||
| public class AssemblyLoadTests | ||
| { | ||
| [Fact] |
Collaborator
Author
There was a problem hiding this comment.
file is placeholder for scaffolding. will be removed in next pr
Draft
GarrettBeatty
force-pushed
the
GarrettBeatty/stack/1
branch
from
a90329b to
bc12581
Compare
normj
requested changes
May 12, 2026
| <Import Project="..\..\..\buildtools\common.props" /> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net8.0</TargetFramework> |
Member
There was a problem hiding this comment.
Can you use the $(DefaultPackageTargets) msbuild property I added in my previous PR?
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net8.0</TargetFramework> |
Member
There was a problem hiding this comment.
Can you use the $(DefaultPackageTargets) msbuild property I added in my previous PR?
GarrettBeatty
force-pushed
the
GarrettBeatty/stack/1
branch
from
bc12581 to
9eff24c
Compare
normj
reviewed
May 12, 2026
| <Import Project="..\..\..\buildtools\common.props" /> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>$(DefaultPackageTargets)</TargetFramework> |
Member
There was a problem hiding this comment.
Since $(DefaultPackageTargets) has multiple targets, .NET 8 and 10. You need to change TargetFramework to TargetFrameworks.
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>$(DefaultPackageTargets)</TargetFramework> |
Member
There was a problem hiding this comment.
Since $(DefaultPackageTargets) has multiple targets, .NET 8 and 10. You need to change TargetFramework to TargetFrameworks.
Establishes the package metadata for the durable execution SDK: src project (net8.0, trimmable, signed) and the matching test project with InternalsVisibleTo wired up. No public API is added yet — a single sanity test verifies the assembly loads. Subsequent PRs will add the actual SDK contents on top of this scaffolding. stack-info: PR: #2359, branch: GarrettBeatty/stack/1 build PR comments PR comments
GarrettBeatty
force-pushed
the
GarrettBeatty/stack/1
branch
from
9eff24c to
b590506
Compare
normj
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Add Amazon.Lambda.DurableExecution project scaffolding
Establishes the package metadata for the durable execution SDK:
src project (net8.0, trimmable, signed) and the matching test project
with InternalsVisibleTo wired up. No public API is added yet — a
single sanity test verifies the assembly loads.
Subsequent PRs will add the actual SDK contents on top of this scaffolding.
build
PR comments
PR comments