Added custom formatting possibility#14
Merged
normj merged 1 commit intoaws:masterfrom Jun 22, 2017
peterdeme:master
Merged
Conversation
|
Thanks for the PR @peterdeme. I will review this and get back to you |
Author
|
Thanks @spati2 |
Author
|
Hi @spati2 , can this be reviewed? We are in kind of a hurry with this implementation. |
Member
|
Thanks for the pull request. I'll work on getting these changes released. |
Author
|
Thanks @normj ! Appreciate it |
Member
|
I just pushed out version 1.2.0 of AWS.Logger.AspNetCore that has this pull request in it. Thanks again for the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Spati2 & Norm & AWS Dev Team,
First of all, thank you for this great library. We just started to use it and it's great.
Although we are missing a functionality. For us, it's very important that we need to be able to customize the messages. For example: we need to have a transaction id injected to every one of our messages, and we want to see the LogLevel as well. This is very important to us, and this can be solved if we can provide our own formatter. Currently, unfortunately that is not possible.
ASP.NET Core (Kestrel, EF etc.) internally uses LogDebug, LogInformation, LogTrace etc. overloads of ILogger where the default formatter is getting applied. We want to format even the ASPNET Core internal logging messages, so in order to achieve this, the Log() overload needs to be customized like I did.
Thank you!
Peter