Skip to content

Refactor Changelog updates in priority order #2848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2024
Merged

Refactor Changelog updates in priority order #2848

merged 1 commit into from
Dec 10, 2024

Conversation

@dreambeyondorange
Copy link
Contributor

@dreambeyondorange dreambeyondorange commented Dec 10, 2024

Description of changes

  • Describe what you're changing and why you're doing these changes.

Tests

  • Describe the automated and/or manual tests executed to validate the patch.
  • Describe the added/modified tests.

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dreambeyondorange dreambeyondorange requested review from a team as code owners December 10, 2024 02:50
@dreambeyondorange dreambeyondorange enabled auto-merge (squash) December 10, 2024 02:53
@dreambeyondorange dreambeyondorange merged commit 40c2d54 into aws:release-3.12 Dec 10, 2024
31 checks passed
himani2411 added a commit that referenced this pull request Dec 26, 2024
@gmarciani @dreambeyondorange @himani2411
On Ubuntu22, install the NVIDIA driver using the gcc version used to …
1b7fb9f 
…compile the kernel. (#2852)

* Refactor Changelog updates in priority order (#2848)

* Update CHANGELOG.md to remove 'we' (#2851)

* [nvidia] On Ubuntu22, install the NVIDIA driver using the gcc version used to compile the kernel.

This is required because, NVIDIA driver must be compiled with the same gcc version used by the kernel.
If this is not the case, the NVIDIA driver installation would fail a compiler version check.
On newer version of Ubuntu22.04 (kernel 6.8+), the kernel is compiled with gcc-12, however gcc-11 is installed as default version by build-essentials, making this change necessary.

Signed-off-by: Giacomo Marciani <mgiacomo@amazon.com>

* [CI] Use Cinc v23 to execute spec tests.

Signed-off-by: Giacomo Marciani <mgiacomo@amazon.com>

---------

Signed-off-by: Giacomo Marciani <mgiacomo@amazon.com>
Co-authored-by: Ryan Anderson <ndry@amazon.com>
Co-authored-by: Himani Anil Deshpande <79726937+himani2411@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmarciani gmarciani gmarciani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dreambeyondorange @gmarciani