-
Notifications
You must be signed in to change notification settings - Fork 110
On Ubuntu22, install the NVIDIA driver using the gcc version used to compile the kernel. #2852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
himani2411
merged 5 commits into
aws:develop
from
gmarciani:wip/mgiacomo/3120/fix-arm-ubuntu-1211-1
Dec 26, 2024
Merged
On Ubuntu22, install the NVIDIA driver using the gcc version used to compile the kernel. #2852
himani2411
merged 5 commits into
aws:develop
from
gmarciani:wip/mgiacomo/3120/fix-arm-ubuntu-1211-1
Dec 26, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc3f41b
to
48f8bc8
Compare
c4747c4
to
50c493d
Compare
0b03399
to
f438831
Compare
… used to compile the kernel. This is required because, NVIDIA driver must be compiled with the same gcc version used by the kernel. If this is not the case, the NVIDIA driver installation would fail a compiler version check. On newer version of Ubuntu22.04 (kernel 6.8+), the kernel is compiled with gcc-12, however gcc-11 is installed as default version by build-essentials, making this change necessary. Signed-off-by: Giacomo Marciani <mgiacomo@amazon.com>
f438831
to
a0ea069
Compare
Signed-off-by: Giacomo Marciani <mgiacomo@amazon.com>
demartinofra
previously approved these changes
Dec 13, 2024
The base branch was changed.
hanwen-cluster
approved these changes
Dec 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove based on demartinofra's approval
gmarciani
added a commit
to gmarciani/aws-parallelcluster-cookbook
that referenced
this pull request
Feb 17, 2025
…ver. We remove it because: 1/ it is not supported anymore by the NVIDIA installer. 2/ it was an unsafe workaround introduced in 3.8.0 (aws#2404), which was supposed to be there only in the short term and in ended be there for long time. 3/ we introduced in 3.12.0 a logic to install NVIDIA drivers using the gcc version used to compile the kernel aws#2852.
gmarciani
added a commit
to gmarciani/aws-parallelcluster-cookbook
that referenced
this pull request
Feb 17, 2025
…ver. We remove it because: 1/ it is not supported anymore by the NVIDIA installer. 2/ it was an unsafe workaround introduced in 3.8.0 (aws#2404), which was supposed to be there only in the short term and in ended be there for long time. 3/ we introduced in 3.12.0 a logic to install NVIDIA drivers using the gcc version used to compile the kernel aws#2852.
gmarciani
added a commit
to gmarciani/aws-parallelcluster-cookbook
that referenced
this pull request
Feb 17, 2025
…ver. We remove it because: 1/ it is not supported anymore by the NVIDIA installer. 2/ it was an unsafe workaround introduced in 3.8.0 (aws#2404), which was supposed to be there only in the short term and in ended be there for long time. 3/ we introduced in 3.12.0 a logic to install NVIDIA drivers using the gcc version used to compile the kernel aws#2852.
gmarciani
added a commit
that referenced
this pull request
Feb 19, 2025
…ver. We remove it because: 1/ it is not supported anymore by the NVIDIA installer. 2/ it was an unsafe workaround introduced in 3.8.0 (#2404), which was supposed to be there only in the short term and in ended be there for long time. 3/ we introduced in 3.12.0 a logic to install NVIDIA drivers using the gcc version used to compile the kernel #2852.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
On Ubuntu22, install the NVIDIA driver using the gcc version used to compile the kernel.
This is required because, NVIDIA driver must be compiled with the same gcc version used by the kernel.
If this is not the case, the NVIDIA driver installation would fail a compiler version check.
On newer version of Ubuntu22.04 (kernel 6.8+), the kernel is compiled with gcc-12, however gcc-11 is installed as default version by build-essentials, making this change necessary.
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.