ignore endpoint discovery for endpoint override - #3572
Merged
Conversation
sbaluja
approved these changes
Sep 29, 2025
sbiscigl
force-pushed
the
timestream-query-ep-discovery
branch
2 times, most recently
from
September 30, 2025 12:53
39a230a to
1e92e9c
Compare
sbiscigl
marked this pull request as ready for review
September 30, 2025 13:40
sbiscigl
marked this pull request as draft
September 30, 2025 13:42
sbiscigl
marked this pull request as ready for review
September 30, 2025 13:42
sbiscigl
force-pushed
the
timestream-query-ep-discovery
branch
from
September 30, 2025 15:26
1e92e9c to
229c8ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#3568
Description of changes:
Very similar to a .NET issue aws/aws-sdk-net#3349 the we also have where we attempt endpoint discovery when the endpoint is overridden. This is not the desired behavior we want to use the overridden endpoint skipping discovery all together. this aligns with the .NET solution.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.