fix: restore public visibility on constructor for EcsCredentialsProvider
#1049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauzadis
approved these changes
Sep 18, 2023
aajtodd
approved these changes
Sep 19, 2023
Contributor
aajtodd
left a comment
aajtodd
left a comment
There was a problem hiding this comment.
Failing e2e tests and service check batch needs looked at before merge but looks good.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Fixes #1048
Description of changes
#1042 accidentally removed the public constructor for
EcsCredentialsProvider, leaving no way to instantiate it manually. This change promotes theinternalconstructor topublic.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.