Skip to content

fix: restore public visibility on constructor for EcsCredentialsProvider #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2023
Merged

fix: restore public visibility on constructor for EcsCredentialsProvider #1049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26d3270
fix: restore public visibility on constructor for `EcsCredentialsProv…
ianbotsf Sep 18, 2023
bb8a1f5
Merge remote-tracking branch 'origin/main' into fix-ecscredprov-const…
ianbotsf Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changes/c80024c2-a966-42c6-8037-0e0382d6ea89.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"id": "c80024c2-a966-42c6-8037-0e0382d6ea89",
"type": "bugfix",
"description": "Restore public constructor for `EcsCredentialsProvider`",
"issues": [
"awslabs/aws-sdk-kotlin#1048"
]
}
2 changes: 2 additions & 0 deletions aws-runtime/aws-config/api/aws-config.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ public final class aws/sdk/kotlin/runtime/auth/credentials/DefaultChainCredentia

public final class aws/sdk/kotlin/runtime/auth/credentials/EcsCredentialsProvider : aws/smithy/kotlin/runtime/auth/awscredentials/CloseableCredentialsProvider {
public fun <init> ()V
public fun <init> (Laws/smithy/kotlin/runtime/util/PlatformEnvironProvider;Laws/smithy/kotlin/runtime/http/engine/HttpClientEngine;)V
public synthetic fun <init> (Laws/smithy/kotlin/runtime/util/PlatformEnvironProvider;Laws/smithy/kotlin/runtime/http/engine/HttpClientEngine;ILkotlin/jvm/internal/DefaultConstructorMarker;)V
public fun close ()V
public final fun getPlatformProvider ()Laws/smithy/kotlin/runtime/util/PlatformEnvironProvider;
public fun resolve (Laws/smithy/kotlin/runtime/util/Attributes;Lkotlin/coroutines/Continuation;)Ljava/lang/Object;
Expand Down
2 changes: 1 addition & 1 deletion ...e/aws-config/common/src/aws/sdk/kotlin/runtime/auth/credentials/EcsCredentialsProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ private const val PROVIDER_NAME = "EcsContainer"
* are NOT managed by the provider. Caller is responsible for closing.
*
*/
public class EcsCredentialsProvider internal constructor(
public class EcsCredentialsProvider(
public val platformProvider: PlatformEnvironProvider = PlatformProvider.System,
httpClient: HttpClientEngine? = null,
) : CloseableCredentialsProvider {
Expand Down