Skip to content

Conversation

@syall
Copy link
Contributor

@syall syall commented Aug 8, 2022

Issue #

N/A

Description of changes

In preparation of the Smithy IDL 2.0 release, the following change will fix the test case by providing the required @httpPayload trait to the test case.

Error Message with local Smithy IDL 2.0 changes (./gradlew clean build check):

restJson1 has a model that failed validation
[ERROR] aws.sdk.kotlin.test.eventstream#TestStreamInputOutput$value: Member `aws.sdk.kotlin.test.eventstream#TestStreamInputOutput$value` referencing @streaming shape `aws.sdk.kotlin.test.eventstream#TestStream` must have the @httpPayload trait, as service `aws.sdk.kotlin.test.eventstream#TestService` has a protocol that supports @httpPayload. | StreamingTrait /Users/yuasteve/development/codegen/aws-sdk-kotlin/tests/codegen/event-stream/build/restJson1/model.smithy:19:45

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@syall syall requested a review from a team as a code owner August 8, 2022 19:32
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@syall syall merged commit b4a97d4 into aws:main Aug 9, 2022
@syall
Copy link
Contributor Author

syall commented Aug 9, 2022

Not sure why the PR says it was merged, when no commits were merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant