Skip to content

Conversation

@GarrettBeatty
Copy link
Contributor

@GarrettBeatty GarrettBeatty commented Dec 2, 2025

Description

Fix a bug where previously the first part was not utilizing the throttler. this was an issue because in the scenario for directory downloads, where the http throttler is shared across multiple files, it would mean each file would bypass the throttling limits

Motivation and Context

#3806

Testing

  1. unit tests
  2. reran integ tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@GarrettBeatty GarrettBeatty changed the title use throttling for discoverpart Use throttler for first part in multi part Dec 2, 2025
@GarrettBeatty GarrettBeatty marked this pull request as ready for review December 2, 2025 20:26
Base automatically changed from gcbeatty/raceconditionfix to feature/transfermanager December 3, 2025 16:14
@GarrettBeatty GarrettBeatty force-pushed the gcbeatty/discoverusethrottle branch from bb3ee14 to 717b38a Compare December 3, 2025 16:18
@GarrettBeatty GarrettBeatty merged commit 7671451 into feature/transfermanager Dec 3, 2025
1 check passed
@GarrettBeatty GarrettBeatty deleted the gcbeatty/discoverusethrottle branch December 3, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants