Skip to content

Use throttler for first part in multi part #4183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2025
+456 −32
Merged

Use throttler for first part in multi part #4183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 36 additions & 4 deletions sdk/src/Services/S3/Custom/Transfer/Internal/MultipartDownloadManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,8 +486,24 @@ private async Task<DownloadDiscoveryResult> DiscoverUsingPartStrategyAsync(Cance
var firstPartRequest = CreateGetObjectRequest();
firstPartRequest.PartNumber = 1;

// SEP Part GET Step 2: "send the request and wait for the response in a non-blocking fashion"
var firstPartResponse = await _s3Client.GetObjectAsync(firstPartRequest, cancellationToken).ConfigureAwait(false);
// Wait for both capacity types before making HTTP request (consistent with background parts)
Logger.DebugFormat("MultipartDownloadManager: [Part 1 Discovery] Waiting for buffer capacity");
await _dataHandler.WaitForCapacityAsync(cancellationToken).ConfigureAwait(false);

Logger.DebugFormat("MultipartDownloadManager: [Part 1 Discovery] Waiting for HTTP concurrency slot");
await _httpConcurrencySlots.WaitAsync(cancellationToken).ConfigureAwait(false);

GetObjectResponse firstPartResponse = null;
try
{
// SEP Part GET Step 2: "send the request and wait for the response in a non-blocking fashion"
firstPartResponse = await _s3Client.GetObjectAsync(firstPartRequest, cancellationToken).ConfigureAwait(false);
}
finally
{
_httpConcurrencySlots.Release();
Logger.DebugFormat("MultipartDownloadManager: [Part 1 Discovery] HTTP concurrency slot released");
}

if (firstPartResponse == null)
throw new InvalidOperationException("Failed to retrieve object from S3");
Expand Down Expand Up @@ -547,8 +563,24 @@ private async Task<DownloadDiscoveryResult> DiscoverUsingRangeStrategyAsync(Canc
var firstRangeRequest = CreateGetObjectRequest();
firstRangeRequest.ByteRange = new ByteRange(0, targetPartSize - 1);

// SEP Ranged GET Step 2: "send the request and wait for the response in a non-blocking fashion"
var firstRangeResponse = await _s3Client.GetObjectAsync(firstRangeRequest, cancellationToken).ConfigureAwait(false);
// Wait for both capacity types before making HTTP request (consistent with background parts)
Logger.DebugFormat("MultipartDownloadManager: [Part 1 Discovery] Waiting for buffer capacity");
await _dataHandler.WaitForCapacityAsync(cancellationToken).ConfigureAwait(false);

Logger.DebugFormat("MultipartDownloadManager: [Part 1 Discovery] Waiting for HTTP concurrency slot");
await _httpConcurrencySlots.WaitAsync(cancellationToken).ConfigureAwait(false);

GetObjectResponse firstRangeResponse = null;
try
{
// SEP Ranged GET Step 2: "send the request and wait for the response in a non-blocking fashion"
firstRangeResponse = await _s3Client.GetObjectAsync(firstRangeRequest, cancellationToken).ConfigureAwait(false);
}
finally
{
_httpConcurrencySlots.Release();
Logger.DebugFormat("MultipartDownloadManager: [Part 1 Discovery] HTTP concurrency slot released");
}

// Defensive null check
if (firstRangeResponse == null)
Expand Down
Loading