Skip to content

fix(a2a): advertise resolved port on explicit cards - #605

Merged
jariy17 merged 1 commit into
mainfrom
fix/a2a-explicit-card-port
Jul 28, 2026
Merged

fix(a2a): advertise resolved port on explicit cards#605
jariy17 merged 1 commit into
mainfrom
fix/a2a-explicit-card-port

Conversation

@notgitika

Copy link
Copy Markdown
Contributor

Summary

  • update caller-supplied A2A cards with the URL resolved by serve_a2a
  • preserve AGENTCORE_RUNTIME_URL precedence and direct build_a2a_app behavior when no override is supplied
  • add regression coverage for PORT, explicit port=, and deployed runtime URL precedence

Reproduction

Generated ADK and LangGraph templates provide cards that advertise http://localhost:9000/. Outside agentcore dev, running:

PORT=9002 uv run python main.py

binds the server to 9002 but previously left the explicit card URL at 9000. serve_a2a already passes its resolved local URL into build_a2a_app; this change applies that URL to explicit cards as well as generated cards.

Testing

  • uv run pytest tests/bedrock_agentcore/runtime/test_a2a.py -q (31 passed, A2A v1)
  • A2A SDK 0.3 focused suite (30 passed, 1 skipped)
  • uv run pytest tests/bedrock_agentcore/runtime -q (332 passed)
  • uv run pytest tests/integration/runtime/test_a2a_integration.py -q (10 passed)
  • Ruff lint and format checks
  • standalone generated ADK at 9002 advertises http://localhost:9002/
  • standalone generated LangGraph at 9003 advertises http://localhost:9003/

@github-actions

Copy link
Copy Markdown
Contributor

✅ No Breaking Changes Detected

No public API breaking changes found in this PR.

@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Jul 28, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Jul 28, 2026
@jariy17
jariy17 merged commit 34e06f0 into main Jul 28, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants