Update pip requirement from <19.3,>=9 to >=9,<19.4#1273
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1273 +/- ##
==========================================
- Coverage 96.22% 96.19% -0.04%
==========================================
Files 28 28
Lines 5275 5278 +3
Branches 672 673 +1
==========================================
+ Hits 5076 5077 +1
- Misses 129 130 +1
- Partials 70 71 +1
Continue to review full report at Codecov.
|
8ce938c to
11d7b1b
Compare
Updates the requirements on [pip](https://github.com/pypa/pip) to permit the latest version. - [Release notes](https://github.com/pypa/pip/releases) - [Changelog](https://github.com/pypa/pip/blob/master/NEWS.rst) - [Commits](pypa/pip@9.0.0...19.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
11d7b1b to
b67104c
Compare
chalice/compat.py
Outdated
| return 'from pip import main' | ||
| # Pip changed their import structure again in 19.3 | ||
| # https://github.com/pypa/pip/commit/09fd200 | ||
| elif pip_major_version == '19' and int(pip_minor_version) >= 3: |
There was a problem hiding this comment.
We can simplify this a bit and just say (pip_major_version, pip_minor_version) >= (19, 3) to account for future versions. You also want to make sure these are ints.
b67104c to
93c7be0
Compare
jamesls
left a comment
There was a problem hiding this comment.
Can you link the chalice package issue as well? Otherwise looks good.
This patch was provided by hgibsonqb #1272 (comment)
93c7be0 to
3f8f76e
Compare
|
One of your CI runs failed on this pull request, so Dependabot won't merge it. Dependabot will still automatically merge this pull request if you amend it and your tests pass. |
|
One of your CI runs failed on this pull request, so Dependabot won't merge it. Dependabot will still automatically merge this pull request if you amend it and your tests pass. |
Updates the requirements on pip to permit the latest version.
Changelog
Sourced from pip's changelog.
Commits
afcb3e7Release 19.3707fe21Updating AUTHORS.txt8df9329Add release targeta0b75ccRemove intermediate pip-wheel-metadata dir1c3f31cMerge pull request #7072 from TonyBeswick/master8c66447Use python-version instead of deprecated version7e11e25Update AUTHORS.txt7ebc541Fixed missing return statement inMercurial.controls_location(), it24a2be8RevertingVersionControl.controls_location()to pre PR state. Its an optim...f197479Fixed LF getting converted to CRLF in last commit.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot will merge this PR once CI passes on it, as requested by @jamesls.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in the
.dependabot/config.ymlfile in this repo: