feat: support env vars and secrets for sidecars#1725
Merged
mergify[bot] merged 5 commits intoaws:mainlinefrom Nov 30, 2020
Merged
feat: support env vars and secrets for sidecars#1725mergify[bot] merged 5 commits intoaws:mainlinefrom
mergify[bot] merged 5 commits intoaws:mainlinefrom
Conversation
iamhopaul123
force-pushed
the
sidecar/add-var-secret
branch
from
7c986cf to
786c8c0
Compare
iamhopaul123
force-pushed
the
sidecar/add-var-secret
branch
from
786c8c0 to
e5c323f
Compare
iamhopaul123
force-pushed
the
sidecar/add-var-secret
branch
from
e5c323f to
1a5c46e
Compare
huanjani
reviewed
Nov 25, 2020
| destination: | ||
| Name: cloudwatch | ||
| region: us-west-2 | ||
| region: us-east-1 |
Contributor
There was a problem hiding this comment.
I'm just curious why you changed regions here...?
Contributor
Author
There was a problem hiding this comment.
good question it is because our e2e tests are deployed in us-east-1, so that firelens knows where to find the log group and create the log stream in it.
Contributor
Author
There was a problem hiding this comment.
but i do think we need to update the e2e test so that this error can be caught.
Contributor
Author
There was a problem hiding this comment.
ok now it should be able to catch it if the firelens is not able to create the log stream in the log group.
efekarakus
approved these changes
Nov 30, 2020
efekarakus
changed the title
efekarakus
changed the title
iamhopaul123
added
the
do-not-merge
iamhopaul123
removed
the
do-not-merge
iamhopaul123
commented
Nov 30, 2020
| @@ -1,2 +1,8 @@ | |||
| FROM nginx | |||
| COPY nginx.conf /etc/nginx/nginx.conf | |||
| FROM nginx:1.15-alpine | |||
Contributor
Author
There was a problem hiding this comment.
huanjani
approved these changes
Nov 30, 2020
kahirul
reviewed
Dec 28, 2020
| port: 80 | ||
| image: %s # Image URL for sidecar container. | ||
| variables: | ||
| NGINX_PORT: %s |
Contributor
There was a problem hiding this comment.
Is it possible to set variables or secrets per-environment, i.e. dev and prod?
Contributor
Author
There was a problem hiding this comment.
Yeah I think you can do the override like this
sidecars:
nginx:
port: 80
image: %s # Image URL for sidecar container.
variables:
NGINX_PORT: 80
environments:
dev:
sidecars:
nginx:
variables:
NGINX_PORT: 8080
prod:
sidecars:
nginx:
variables:
NGINX_PORT: 5000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1119
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.