feat(cicd): allow CodeCommit as pipeline source

[huanjani]

This PR enables CodeCommit as a pipeline source through execution

(while still allowing GitHub as a source).

Resolves #781
Related #1339

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[iamhopaul123]

This is awesome! Thank you so much. Can we also make sure that integ test works well for this change?

[efekarakus]

🚀

[bvtujo]

Do these fields come from deploy.GithubSource or manifest.GithubProperties, or somewhere else? In those structs the field is RepositoryURL, not Repository--is that correct?

[huanjani]

Good question-- this is confusing.
Repository is the method (func (s *GitHubSource) Repository() (string, error)) in the deploy package that returns the repo of a GitHubSource. For this field, we want just the repo name, not the whole url.

[bvtujo]

Interesting, so Go will call the method named there. I talked about this in another comment where I think we can combine a base struct with a public ProviderName method and generator function. It's not super necessary though so if you think it's too much bother feel free to 🚀

[bvtujo]

Is this the same struct which determines the values that get injected into CFN? Is that why we need the ProviderName struct member?

[huanjani]

Yeah--I had taken it out because it seemed redundant, but this seemed to be the most straightforward way to determine which chunk of the yaml should get applied to the template.

I may change this when I introduce other sources and partials. Let me know if you have ideas!

[bvtujo]

We could create a base pipelineSource struct which has a ProviderName() method and include that as a member of both GithubSource and CodeCommitSource, as something like

type pipelineSource struct {
    providerName string
}

func (s *pipelineSource) ProviderName() string {
    return s.providerName
}

type GithubSource struct {
    *pipelineSource
    // other GH specific members
}

func NewGithubSource(url, branch, secretID string) GithubSource {
    return GithubSource{
        pipelineSource: &pipelineSource{
            providerName: manifest.GithubProviderName
        },
        // other members
    }
}

[huanjani]

This is cool! I implemented it locally but didn't commit because it may overcomplicate things at this point (unless there's a benefit to the cfn template calling a method rather than a struct field). I'll keep this in mind, though, if we have more functionality to add to this set-up with more sources.

[bvtujo]

There's no particular benefit except
a) limiting code redeclaration in the various pipeline providers
b) making it harder to incorrectly initialize GithubSource or CodeCommitSource with the wrong provider name.

If the struct becomes more complicated then I think it would be worth it to move to the constructor pattern above but for the time being it's totally fine to leave as is.