feat(cli): add task delete command#1849
Merged
mergify[bot] merged 6 commits intoaws:mainlinefrom Jan 27, 2021
Merged
Conversation
bvtujo
added
the
do-not-merge
bvtujo
force-pushed
the
app-delete-tasks
branch
2 times, most recently
from
e3d82d7 to
f1032ca
Compare
bvtujo
force-pushed
the
app-delete-tasks
branch
from
f1032ca to
be41212
Compare
efekarakus
reviewed
Jan 25, 2021
Contributor
efekarakus
left a comment
efekarakus
left a comment
There was a problem hiding this comment.
Looks great! just some documentation suggestions
| 3. Delete the CloudFormation stack, including the ECR repo, log group, and ECS Task Definition. | ||
|
|
||
| !!!info | ||
| 1. Tasks created with versions of Copilot earlier than v1.2.0 cannot be stopped by `copilot task delete`. Customers using tasks launched with earlier versions should manually stop any running tasks via the ECS console after running the command. |
Contributor
There was a problem hiding this comment.
What was the reason for this?
Contributor
Author
There was a problem hiding this comment.
Previously, the call in task run to ecs.RunTask did not have the PropagateTags: aws.String(ecs.PropagateTagsTaskDefinition) property set so the tasks cannot be reliably identified as Copilot-initiated.
Contributor
Author
There was a problem hiding this comment.
The side effect would be the ability to stop tasks from a one-off task definition not started by copilot.
Contributor
There was a problem hiding this comment.
ooh yeaa gotcha, thanks for the clarification
efekarakus
approved these changes
Jan 25, 2021
iamhopaul123
approved these changes
Jan 26, 2021
bvtujo
removed
the
do-not-merge
Contributor
Author
|
Revised E2E test passes. |
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
<!-- Provide summary of changes --> This PR does the following: * Adds `task delete` as a new command * Adds a step in `app delete` during which all existing tasks in the application's environments are deleted * Rephrases the e2e test for tasks to use the new command on teardown * Adds documentation of the new command. <!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" --> Depends on aws#1840 being merged in. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
task deleteas a new commandapp deleteduring which all existing tasks in the application's environments are deletedDepends on #1840 being merged in.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.