fix(template): Option with value as "on" is converted to true#1857
Merged
mergify[bot] merged 2 commits intoaws:mainlinefrom Jan 21, 2021
kahirul:escape-option-value
Merged
fix(template): Option with value as "on" is converted to true#1857mergify[bot] merged 2 commits intoaws:mainlinefrom kahirul:escape-option-value
mergify[bot] merged 2 commits intoaws:mainlinefrom
kahirul:escape-option-value
Conversation
kahirul
changed the title
Contributor
|
Hello @kahirul. I'm using the latest binary and it seems like when I specified LogConfiguration:
LogDriver: awsfirelens
Options:
Name: datadog
TLS: on
- Name: firelens_log_router
Image: amazon/aws-for-fluent-bit:latest
FirelensConfiguration:
Type: fluentbit
Options:
enable-ecs-log-metadata: true
config-file-type: file
config-file-value: /fluent-bit/configs/parse-json.confI was wondering how you produced |
Contributor
Author
You're right. Both CFN template and |
iamhopaul123
approved these changes
Jan 21, 2021
Contributor
iamhopaul123
left a comment
iamhopaul123
left a comment
There was a problem hiding this comment.
Ship it! Thank you so much for contributing and fixing this bug!
efekarakus
approved these changes
Jan 21, 2021
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
```
logging:
image: amazon/aws-for-fluent-bit:latest
destination:
Name: datadog
TLS: on
```
will produce something like `"TLS": "true"`
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
will produce something like
"TLS": "true"By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.