feat: enable mounting external EFS volumes in Copilot jobs & services#1971
Merged
mergify[bot] merged 5 commits intoaws:mainlinefrom Feb 25, 2021
Merged
feat: enable mounting external EFS volumes in Copilot jobs & services#1971mergify[bot] merged 5 commits intoaws:mainlinefrom
mergify[bot] merged 5 commits intoaws:mainlinefrom
Conversation
efekarakus
approved these changes
Feb 24, 2021
| {{- end -}} | ||
| {{include "sidecars" . | indent 8}} | ||
| {{- if .Storage}} | ||
| {{- if .Storage -}} |
Contributor
There was a problem hiding this comment.
oh does adding "-}}" remove an extra new line for these if blocks?
Contributor
Author
There was a problem hiding this comment.
yeah, that's right. It trims whitespace until the next directive. In these sections of template where there are multiple lines of interpolations one after another sometimes an extra newline can sneak in. The trailing -}} fixes that. I don't want to do it everywhere but it's helpful sometimes to clean up the rendered CF.
Contributor
|
I assume we'll update the docs in a separate PR? |
Contributor
Author
|
Yeah, I'm working on that one right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.