feat(manifest): enable "network" field to specify subnets and sec groups#1979
Merged
mergify[bot] merged 5 commits intoaws:mainlinefrom Feb 26, 2021
Merged
Conversation
efekarakus
requested review from
Lou1415926,
bvtujo,
huanjani and
iamhopaul123
huanjani
reviewed
Feb 26, 2021
| data: ` | ||
| network: | ||
| vpc: | ||
| placement: 'tartarus' |
bvtujo
approved these changes
Feb 26, 2021
Contributor
bvtujo
left a comment
bvtujo
left a comment
There was a problem hiding this comment.
This looks really slick! Nice work with the code to enable these changes.
huanjani
added a commit
to huanjani/amazon-ecs-cli-v2
that referenced
this pull request
Feb 26, 2021
9 tasks
Closed
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
…oups (aws#1979) The manifests now support the following new fields: ```yaml network: vpc: placement: 'public|private' # which subnets to place the tasks. security_groups: [string] # list of additional security groups. ``` The `network.vpc.placement` field won't be really useful atm for customers that use Copilot generated VPCs since we don't create NAT gateways. However, it will be supported in the future. This is milestone 1. of aws#1959. On the other hand, customers that imported their VPC while creating an environment will now be able to place their tasks in private subnets. The security groups feature is available for everyone to attach additional security groups to their tasks. Related aws#1959 Closes aws#1453 _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manifests now support the following new fields:
The
network.vpc.placementfield won't be really useful atm for customers that use Copilot generated VPCs since we don't create NAT gateways. However, it will be supported in the future. This is milestone 1. of #1959.On the other hand, customers that imported their VPC while creating an environment will now be able to place their tasks in private subnets.
The security groups feature is available for everyone to attach additional security groups to their tasks.
Related #1959
Closes #1453
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.