fix(cicd): remove Name field for test command build projects#2003
Merged
mergify[bot] merged 4 commits intoaws:mainlinefrom Mar 3, 2021
Merged
fix(cicd): remove Name field for test command build projects#2003mergify[bot] merged 4 commits intoaws:mainlinefrom
mergify[bot] merged 4 commits intoaws:mainlinefrom
Conversation
efekarakus
reviewed
Mar 2, 2021
efekarakus
reviewed
Mar 3, 2021
efekarakus
approved these changes
Mar 3, 2021
efekarakus
changed the title
iamhopaul123
approved these changes
Mar 3, 2021
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
This change gives Copilot pipelines more flexibility, as it enables users to build pipelines that share an app and env, but different repos/svcs or branches. We are seeing that customers want to build multiple pipelines for single apps, and this makes our pipeline functionality more extensible by avoiding overlapping CodeBuild project names. We have [255 characters](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-codebuild-project.html#cfn-codebuild-project-name) to work with, so stringing together `BuildTestCommands-[appName]-[env/stageName]-[repoName]-[branchName]` should be okay. Fixes aws#1986. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change gives Copilot pipelines more flexibility, as it enables users to build pipelines that share an app and env, but different repos/svcs or branches. We are seeing that customers want to build multiple pipelines for single apps, and this makes our pipeline functionality more extensible by avoiding overlapping CodeBuild project names.
We have 255 characters to work with, so stringing together
BuildTestCommands-[appName]-[env/stageName]-[repoName]-[branchName]should be okay.UPDATE: We removed the Name field entirely.
Fixes #1986.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.