chore(cicd): switch to CSC for GH sources#2019
Merged
mergify[bot] merged 10 commits intoaws:mainlinefrom Mar 10, 2021
Merged
Conversation
iamhopaul123
reviewed
Mar 5, 2021
Contributor
iamhopaul123
left a comment
iamhopaul123
left a comment
There was a problem hiding this comment.
Sorry i missed so much context about this PR 😰 but I think maybe we could use the methodology to simplify the pipeline code and avoid having very similar functions.
efekarakus
reviewed
Mar 9, 2021
iamhopaul123
approved these changes
Mar 9, 2021
Contributor
iamhopaul123
left a comment
iamhopaul123
left a comment
There was a problem hiding this comment.
Wow this is so good! Much better than the previous version I reviewed last time. Good job 🎉
efekarakus
reviewed
Mar 10, 2021
Contributor
efekarakus
left a comment
efekarakus
left a comment
There was a problem hiding this comment.
Looks good! v minor feedback and then 
efekarakus
approved these changes
Mar 10, 2021
efekarakus
changed the title
mergify Bot
pushed a commit
that referenced
this pull request
Mar 10, 2021
…ource changes (#2038) Update docs to reflect shift from use personal access tokens to CodeStar Connections for connecting to GitHub repositories when creating pipelines. Renamed old "GH" test files to "GHV1" and added new (v2) "GH" `stack` integ tests but not `cloudformation` integ tests because of polling. Related #2019. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
This PR changes the way we connect to GitHub repo providers going forward. If users pass in a `--github-access-token` flag (now hidden) when running `pipeline init`, the pipeline will connect via a [version 1](https://docs.aws.amazon.com/codepipeline/latest/userguide/update-github-action-connections.html) connection; existing pipelines with `access_token_secret` in their manifests will continue to use their existing (version 1) connection when running `pipeline update`. Otherwise, the connection will use CodeStar Connections and the workflow will look like that for Bitbucket (polling for connection update, etc.). Integ test and doc updates and refactoring to come out in separate PRs. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
…ource changes (aws#2038) Update docs to reflect shift from use personal access tokens to CodeStar Connections for connecting to GitHub repositories when creating pipelines. Renamed old "GH" test files to "GHV1" and added new (v2) "GH" `stack` integ tests but not `cloudformation` integ tests because of polling. Related aws#2019. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the way we connect to GitHub repo providers going forward. If users pass in a
--github-access-tokenflag (now hidden) when runningpipeline init, the pipeline will connect via a version 1 connection; existing pipelines withaccess_token_secretin their manifests will continue to use their existing (version 1) connection when runningpipeline update. Otherwise, the connection will use CodeStar Connections and the workflow will look like that for Bitbucket (polling for connection update, etc.).Integ test and doc updates and refactoring to come out in separate PRs.
Related #1339.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.