feat(pipelines): install Docker in test_commands CodeBuild project#2097
feat(pipelines): install Docker in test_commands CodeBuild project#2097mergify[bot] merged 4 commits intoaws:mainlinefrom
test_commands CodeBuild project#2097Conversation
bvtujo
left a comment
There was a problem hiding this comment.
Looks great! Do we need to update any integration tests for this?
They're passing locally. I updated the stack/pipeline ones. It'd be nice to eventually test containerized tests where we test |
|
Suggestion: the environment variable for the AWS_ACCOUNT_ID can also be exposed here like it is for the main build. It could be helpful when pulling images from an ECR private repository, which in turn is helpful to avoid Docker Hub pull limits. |
ceagan
left a comment
There was a problem hiding this comment.
I was able to pull these changes and test with a sandbox build I've been working on and it works perfectly! Thanks!
Thanks for this suggestion (and for your Gitter post that got this ball rolling)! |
…ws#2097) If users have their tests configured in containers, they can now use `docker build` commands in the `test_commands` field of the pipeline manifest. Addresses aws#1280. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
If users have their tests configured in containers, they can now use
docker buildcommands in thetest_commandsfield of the pipeline manifest.Addresses #1280.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.