feat(vpc): enable NAT gateway creation for svcs placed in private subnets#2111
Merged
mergify[bot] merged 7 commits intoaws:mainlinefrom Apr 3, 2021
Merged
feat(vpc): enable NAT gateway creation for svcs placed in private subnets#2111mergify[bot] merged 7 commits intoaws:mainlinefrom
mergify[bot] merged 7 commits intoaws:mainlinefrom
Conversation
Lou1415926
reviewed
Mar 29, 2021
Contributor
Lou1415926
left a comment
Lou1415926
left a comment
There was a problem hiding this comment.
looks good! just a few thoughts ⬇️
… remove template function
efekarakus
reviewed
Apr 1, 2021
Contributor
efekarakus
left a comment
efekarakus
left a comment
There was a problem hiding this comment.
Looks great! Just a few small things
efekarakus
approved these changes
Apr 2, 2021
Contributor
efekarakus
left a comment
efekarakus
left a comment
There was a problem hiding this comment.
Nice! We checked that this works fine right :D
efekarakus
added
the
do-not-merge
Contributor
Author
Yup. |
huanjani
removed
the
do-not-merge
9 tasks
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
…nets (aws#2111) This uses the template from aws#2076 to create NAT Gateways when Copilot users deploy their services in private subnets and use a default Copilot-generated VPC (as opposed to importing their own). Related: aws#1959. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the template from #2076 to create NAT Gateways when Copilot users deploy their services in private subnets and use a default Copilot-generated VPC (as opposed to importing their own).
Related: #1959.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.