fix: validation of dynamodb attribute name#2135
Merged
mergify[bot] merged 5 commits intomainlinefrom Apr 5, 2021
unknown repository
Merged
fix: validation of dynamodb attribute name#2135mergify[bot] merged 5 commits intomainlinefrom unknown repository
mergify[bot] merged 5 commits intomainlinefrom
unknown repository
Conversation
ghost
self-requested a review
as a 
ghost
changed the title
Lou1415926
reviewed
Apr 2, 2021
Contributor
Lou1415926
left a comment
Lou1415926
left a comment
There was a problem hiding this comment.
Thank you so much for the fix!!! We really appreciate it 🙇🏼♀️
| err = dynamoAttributeNameValidation(*attr.Name) | ||
| if err != nil { | ||
| return errValueBadFormatWithPeriodUnderscore | ||
| return errDDBAttributeBadSize |
Contributor
There was a problem hiding this comment.
Maybe we can return err here since it's also possible that err = errValueNotAString
Author
There was a problem hiding this comment.
Thank you for your review. I agree with you and made another commit.
Lou1415926
approved these changes
Apr 5, 2021
Contributor
Lou1415926
left a comment
Lou1415926
left a comment
There was a problem hiding this comment.
Looks great! Thank you very much for the fix!!
efekarakus
reviewed
Apr 5, 2021
| if err != nil { | ||
| return errDDBAttributeBadFormat | ||
| } | ||
| err = dynamoTableNameValidation(*attr.Name) |
Contributor
There was a problem hiding this comment.
Is dynamoTableNameValidation used anywhere? if not can we delete it as well?
Contributor
There was a problem hiding this comment.
I think it is still in use in storage_init.go to validate DDB table name
efekarakus
approved these changes
Apr 5, 2021
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
Fixes aws#2134 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2134
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.