feat(cli): add --secrets flag to task run#2163
Merged
mergify[bot] merged 5 commits intoaws:mainlinefrom Apr 14, 2021
Merged
Conversation
iamhopaul123
reviewed
Apr 9, 2021
Contributor
iamhopaul123
left a comment
iamhopaul123
left a comment
There was a problem hiding this comment.
The code LGTM. Do we need to make our unit tests cover this secret usage?
efekarakus
added
the
do-not-merge
huanjani
reviewed
Apr 13, 2021
huanjani
reviewed
Apr 13, 2021
huanjani
approved these changes
Apr 13, 2021
Contributor
huanjani
left a comment
huanjani
left a comment
There was a problem hiding this comment.
Looks great! Thanks for making those extra fixes, too!
efekarakus
removed
the
do-not-merge
efekarakus
changed the title
efekarakus
approved these changes
Apr 14, 2021
Contributor
efekarakus
left a comment
efekarakus
left a comment
There was a problem hiding this comment.
Looks great! Just to make sure, did we test this both with SSM secrets and secret manager secrets?
Lou1415926
added a commit
to Lou1415926/copilot-cli
that referenced
this pull request
Apr 20, 2021
Allow user to specify a list of secrets they want to inject into the container. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Lou1415926
added a commit
to Lou1415926/copilot-cli
that referenced
this pull request
Apr 20, 2021
Allow user to specify a list of secrets they want to inject into the container. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
Allow user to specify a list of secrets they want to inject into the container. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow user to specify a list of secrets they want to inject into the container.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.