fix(cli): prevent pipeline status errors#2170
Merged
mergify[bot] merged 5 commits intoaws:mainlinefrom Apr 15, 2021
Merged
Conversation
efekarakus
added
do-not-merge
efekarakus
reviewed
Apr 14, 2021
efekarakus
approved these changes
Apr 14, 2021
Lou1415926
reviewed
Apr 14, 2021
Contributor
Lou1415926
left a comment
Lou1415926
left a comment
There was a problem hiding this comment.
LGTM! A small suggestion below ⬇️
iamhopaul123
approved these changes
Apr 15, 2021
Lou1415926
pushed a commit
to Lou1415926/copilot-cli
that referenced
this pull request
Apr 20, 2021
This fixes two bugs in `pipeline status`-- previously, the command was throwing a nil pointer error when the prompter was being used, and `describe` threw an error when there was no pipeline name. It was also returning the pipeline status of the pipeline found in the manifest if there were no pipelines associated with the app name passed in with the flag. Now the command behaves as expected. Fixes aws#2004. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Lou1415926
pushed a commit
to Lou1415926/copilot-cli
that referenced
this pull request
Apr 20, 2021
This fixes two bugs in `pipeline status`-- previously, the command was throwing a nil pointer error when the prompter was being used, and `describe` threw an error when there was no pipeline name. It was also returning the pipeline status of the pipeline found in the manifest if there were no pipelines associated with the app name passed in with the flag. Now the command behaves as expected. Fixes aws#2004. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
This fixes two bugs in `pipeline status`-- previously, the command was throwing a nil pointer error when the prompter was being used, and `describe` threw an error when there was no pipeline name. It was also returning the pipeline status of the pipeline found in the manifest if there were no pipelines associated with the app name passed in with the flag. Now the command behaves as expected. Fixes aws#2004. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two bugs in
pipeline status-- previously, the command was throwing a nil pointer error when the prompter was being used, anddescribethrew an error when there was no pipeline name. It was also returning the pipeline status of the pipeline found in the manifest if there were no pipelines associated with the app name passed in with the flag. Now the command behaves as expected.Fixes #2004.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.