feat: add labels to allow runtime labels on containers#2186
Merged
mergify[bot] merged 11 commits intoaws:mainlinefrom Apr 21, 2021
Merged
feat: add labels to allow runtime labels on containers#2186mergify[bot] merged 11 commits intoaws:mainlinefrom
labels to allow runtime labels on containers#2186mergify[bot] merged 11 commits intoaws:mainlinefrom
Conversation
efekarakus
reviewed
Apr 19, 2021
Contributor
efekarakus
left a comment
efekarakus
left a comment
There was a problem hiding this comment.
Yay thank you for following-up on this!
Contributor
iamhopaul123
left a comment
iamhopaul123
left a comment
There was a problem hiding this comment.
Thank you so much for continuing this PR!
Co-authored-by: Efe Karakus <efekarakus@gmail.com>
efekarakus
added
the
do-not-merge
efekarakus
approved these changes
Apr 21, 2021
Contributor
efekarakus
left a comment
efekarakus
left a comment
There was a problem hiding this comment.
LGTM! just the doc change below, feel free to remove the label when its ready. I wonder if we should also add this field to the sidecar docs as well?
efekarakus
reviewed
Apr 21, 2021
| - Name: !Ref WorkloadName | ||
| Image: !Ref ContainerImage | ||
| {{include "container-definition-base-properties" . | indent 6}} | ||
| {{include "envvars" . | indent 10}} |
Contributor
There was a problem hiding this comment.
Was there a reason why we didn't include "envvars" to the new template?
Contributor
Author
There was a problem hiding this comment.
LB web services have the LB URL as an extra environment variable and that adds messy conditionals.
Contributor
Author
There was a problem hiding this comment.
Fixed in latest commit.
| @@ -0,0 +1,13 @@ | |||
| ContainerDefinitions: | |||
Contributor
There was a problem hiding this comment.
I think we should take either one of these routes:
- Transform this file to
container-definitions.ymland includesidecarshere. - Or alternatively rename this file to
workload-container.ymland moveContainerDefinitionsoutside of this file so thatsidecars.ymland this file ends up being individual elements in the list
Contributor
Author
There was a problem hiding this comment.
I've done 2) in the latest commit.
bvtujo
removed
the
do-not-merge
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
<!-- Provide summary of changes --> Incorporates and builds on top of aws#2165. This addresses @efekarakus' feedback and adds a test. <!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" --> By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorporates and builds on top of #2165. This addresses @efekarakus' feedback and adds a test.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.