fix(cicd): upload pipeline template to S3 bucket to prevent hitting size limit#2200
Merged
mergify[bot] merged 10 commits intoaws:mainlinefrom Apr 23, 2021
Merged
fix(cicd): upload pipeline template to S3 bucket to prevent hitting size limit#2200mergify[bot] merged 10 commits intoaws:mainlinefrom
mergify[bot] merged 10 commits intoaws:mainlinefrom
Conversation
huanjani
commented
Apr 21, 2021
| } | ||
|
|
||
| // Execute creates a new pipeline or updates the current pipeline if it already exists. | ||
| func (o *updatePipelineOpts) Execute() error { |
Contributor
Author
There was a problem hiding this comment.
Note: there are no changes to Execute()-- in the first commit I just moved this method higher up in the file.
SoManyHs
approved these changes
Apr 22, 2021
Contributor
SoManyHs
left a comment
SoManyHs
left a comment
There was a problem hiding this comment.
Looks fabulous! ✨ had a few code style questions, but nothing blocking 
efekarakus
added
the
do-not-merge
efekarakus
reviewed
Apr 23, 2021
Contributor
efekarakus
left a comment
efekarakus
left a comment
There was a problem hiding this comment.
Looks great! Just a tiny request to remove the conditional from the the cloudformation pkg
efekarakus
removed
the
do-not-merge
efekarakus
approved these changes
Apr 23, 2021
mergify Bot
pushed a commit
that referenced
this pull request
Apr 28, 2021
…hitting size limit (#2200)" (#2228) This reverts commit a8f4b1b. Unfortunately, we are not guaranteed to have an S3 bucket in the application's region unless the user ran `env init` for the same region as the application. Our integration tests caught this bug 🌈 ! We'll patch the earlier fix in a follow-up. _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
…ize limit (aws#2200) The maximum size of a Cloudformation template body is 51,200 bytes. (https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/cloudformation-limits.html) When users have multiple services deployed to multiple environments and they want to build a pipeline, they risk hitting this limit. By uploading the template to an S3 bucket, then passing the template URL to the ChangeSet, we take advantage of S3's multipart upload functionality (https://docs.aws.amazon.com/AmazonS3/latest/userguide/mpuoverview.html) and circumvent the size limit. The size limit for a template passed in via URL is 460,800 bytes. (https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-cloudformation-stackset.html) Fixes aws#2068. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
…hitting size limit (aws#2200)" (aws#2228) This reverts commit a8f4b1b. Unfortunately, we are not guaranteed to have an S3 bucket in the application's region unless the user ran `env init` for the same region as the application. Our integration tests caught this bug 🌈 ! We'll patch the earlier fix in a follow-up. _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The maximum size of a Cloudformation template body is 51,200 bytes. (https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/cloudformation-limits.html)
When users have multiple services deployed to multiple environments and they want to build a pipeline, they risk hitting this limit.
By uploading the template to an S3 bucket, then passing the template URL to the ChangeSet, we take advantage of S3's multipart upload functionality (https://docs.aws.amazon.com/AmazonS3/latest/userguide/mpuoverview.html) and circumvent the size limit.
The size limit for a template passed in via URL is 460,800 bytes. (https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-cloudformation-stackset.html)
Fixes #2068.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.