fix(cloudformation): should not throw ErrChangeSetEmpty when CFN tmp has bad reference#2270
Merged
mergify[bot] merged 4 commits intoaws:mainlinefrom May 7, 2021
Conversation
Contributor
Author
|
Before the fix: After the fix: |
Contributor
|
omg if this is what I think it is... ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ |
efekarakus
approved these changes
May 6, 2021
efekarakus
reviewed
May 6, 2021
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestChangeSet_createAndExecute(t *testing.T) { |
Contributor
There was a problem hiding this comment.
Can we instead capture this part of our exposed APIs like the UpdateStack test instead of creating a separate one here
efekarakus
added
the
do-not-merge
iamhopaul123
force-pushed
the
throw-correct-change-set-error
branch
from
9bb5db0 to
13a320f
Compare
iamhopaul123
removed
the
do-not-merge
bvtujo
approved these changes
May 7, 2021
Contributor
bvtujo
left a comment
bvtujo
left a comment
There was a problem hiding this comment.
This is so good, PH. The new tests look amazing
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
…has bad reference (aws#2270) fixes aws#2089, fixes aws#2257 <!-- Provide summary of changes --> <!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" --> By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2089, fixes #2257
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.