fix(addons): fix typo to allow secondary indices for ddb tables#2349
Merged
mergify[bot] merged 2 commits intoaws:mainlinefrom May 19, 2021
Merged
fix(addons): fix typo to allow secondary indices for ddb tables#2349mergify[bot] merged 2 commits intoaws:mainlinefrom
mergify[bot] merged 2 commits intoaws:mainlinefrom
Conversation
efekarakus
changed the title
efekarakus
approved these changes
May 19, 2021
Contributor
efekarakus
left a comment
efekarakus
left a comment
There was a problem hiding this comment.
Omg thank you so much for this fix!
huanjani
approved these changes
May 19, 2021
Contributor
|
This is now released in v1.7.1 https://github.com/aws/copilot-cli/releases/tag/v1.7.1 thank you so much for the contribution! ❤️ |
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
…2349) Fix case in templates/addons/ddb/cf.yml Also fix test cases in internal/pkg/addon/testdata/merge/{first,wanted}.yaml With this mistake, a query with a secondary index does not work. See https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/access-control-overview.html#access-control-resources By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix case in templates/addons/ddb/cf.yml
Also fix test cases in internal/pkg/addon/testdata/merge/{first,wanted}.yaml
With this mistake, a query with a secondary index does not work.
See https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/access-control-overview.html#access-control-resources
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.