chore: adds queue to the worker service pattern#2647
Merged
mergify[bot] merged 18 commits intoaws:mainlinefrom Jul 27, 2021
Merged
chore: adds queue to the worker service pattern#2647mergify[bot] merged 18 commits intoaws:mainlinefrom
mergify[bot] merged 18 commits intoaws:mainlinefrom
Conversation
Adds subscribe data structures to template workload. Adds template function for generating subscription JSON that lists out subscribed topics, their services, and any related queue they may have.
adds validations, excluding init/deploy checks for another pr
adds queue ds adds queue validators/converters
xar-tol
changed the title
bvtujo
reviewed
Jul 22, 2021
Contributor
bvtujo
left a comment
bvtujo
left a comment
There was a problem hiding this comment.
This is looking really good. Such complex logic and you've handled it quite well.
I have some comments about how we validate the sns topic subscriptions and unmarshal the durations (retention, delay, timeout), but otherwise this looks good and I can't wait to see the template changes.
Lou1415926
reviewed
Jul 23, 2021
Contributor
Lou1415926
left a comment
Lou1415926
left a comment
There was a problem hiding this comment.
Amazing work! Such complex logic and clear break down of PRs.
I have some thoughts and questions below ⬇️
adjusts bools in template to be non-pointer due to CF issues
Lou1415926
approved these changes
Jul 23, 2021
Contributor
Lou1415926
left a comment
Lou1415926
left a comment
There was a problem hiding this comment.
Looking great!!! Nothing major - just two questions and a comment on unit test!
removes act info from queues due to new json generation removes names from queues to prevent replacement errors
bvtujo
added
the
do-not-merge
bvtujo
approved these changes
Jul 26, 2021
Contributor
bvtujo
left a comment
bvtujo
left a comment
There was a problem hiding this comment.
Looks amazing. Such thorough testing and so well constructed!
xar-tol
removed
the
do-not-merge
xar-tol
added
do-not-merge
xar-tol
added a commit
to xar-tol/copilot-cli
that referenced
this pull request
Aug 5, 2021
Adds the option for queues to the base worker structure. Addresses aws#2550 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
Adds the option for queues to the base worker structure. Addresses aws#2550 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the option for queues to the base worker structure.
Addresses #2550
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.