fix: redirect AppRunner services on ARM architectures to AMD #2955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efekarakus
reviewed
Oct 26, 2021
Contributor
efekarakus
left a comment
efekarakus
left a comment
There was a problem hiding this comment.
Yay looks great! Just minor feedback 
efekarakus
approved these changes
Oct 27, 2021
Lou1415926
pushed a commit
to Lou1415926/copilot-cli
that referenced
this pull request
Nov 2, 2021
Previously, ARM -> AMD redirection was failing because we don't surface the `platform` field in RDWS manifests. Now we hard code `linux/amd64` for empty `platform` fields. Fixes aws#2640. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, ARM -> AMD redirection was failing because we don't surface the
platformfield in RDWS manifests.Now we hard code
linux/amd64for emptyplatformfields.Fixes #2640.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.