Skip to content

docs(ja): update additional-aws-resources page#3289

Merged
mergify[bot] merged 8 commits intoaws:mainlinefrom
g-grass:docs/additional-aws-resources-ja
Feb 23, 2022
Merged

docs(ja): update additional-aws-resources page#3289
mergify[bot] merged 8 commits intoaws:mainlinefrom
g-grass:docs/additional-aws-resources-ja

Conversation

@g-grass
Copy link
Copy Markdown
Contributor

@g-grass g-grass commented Feb 16, 2022

This PR is a Japanese version of Additional AWS Resources page.
Added Customizing the Parameters section.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

Preview

@efekarakus
Copy link
Copy Markdown
Contributor

Thank you @g-grass for the pull-request 😍
Just to provide some transparency: @toricls is currently on vacation, but once he comes and approves the PR it should automatically get merged.

@g-grass
Copy link
Copy Markdown
Contributor Author

g-grass commented Feb 22, 2022

Hi @efekarakus
Thank you for your comment!
It's totally fine. Have a nice vacation😀

Copy link
Copy Markdown
Contributor

@toricls toricls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @g-grass! Left some (nit) comments ‪🤗‬

Comment thread site/content/docs/developing/additional-aws-resources.ja.md Outdated
Comment thread site/content/docs/developing/additional-aws-resources.ja.md Outdated
Comment thread site/content/docs/developing/additional-aws-resources.ja.md Outdated
Comment thread site/content/docs/developing/additional-aws-resources.ja.md Outdated
Comment thread site/content/docs/developing/additional-aws-resources.ja.md Outdated
Comment thread site/content/docs/developing/additional-aws-resources.ja.md Outdated
g-grass and others added 6 commits February 22, 2022 13:05
…s.ja.md

Co-authored-by: Tori Hara <toriclstr@gmail.com>
…s.ja.md

Co-authored-by: Tori Hara <toriclstr@gmail.com>
…s.ja.md

Co-authored-by: Tori Hara <toriclstr@gmail.com>
…s.ja.md

Co-authored-by: Tori Hara <toriclstr@gmail.com>
…s.ja.md

Co-authored-by: Tori Hara <toriclstr@gmail.com>
…s.ja.md

Co-authored-by: Tori Hara <toriclstr@gmail.com>
@g-grass
Copy link
Copy Markdown
Contributor Author

g-grass commented Feb 22, 2022

@toricls
Thank you for the review!
I committed all your suggestions.

Copy link
Copy Markdown
Contributor

@toricls toricls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me ✨ Thank you @g-grass!

Copy link
Copy Markdown
Contributor

@Lou1415926 Lou1415926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution ❤️

@mergify mergify Bot merged commit a2ef9b0 into aws:mainline Feb 23, 2022
@g-grass g-grass deleted the docs/additional-aws-resources-ja branch February 25, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants