docs: Updated Environments Concept Page#3330
Merged
mergify[bot] merged 4 commits intoaws:mainlinefrom Mar 7, 2022
Merged
Conversation
- Changed verbiage in VPC and Networking section to explain workloads are placed in public subnet as a cost optimization.
- Changed verbiage in VPC and Networking section to explain workloads are placed in public subnet as a cost optimization.
efekarakus
reviewed
Mar 4, 2022
Contributor
efekarakus
left a comment
efekarakus
left a comment
There was a problem hiding this comment.
yay thank you so much Carlos!
Co-authored-by: Efe Karakus <efekarakus@gmail.com>
csantos
commented
Mar 5, 2022
Contributor
Author
csantos
left a comment
csantos
left a comment
There was a problem hiding this comment.
Thanks for the suggestions! I've gone ahead and committed them.
huanjani
approved these changes
Mar 7, 2022
Contributor
huanjani
left a comment
huanjani
left a comment
There was a problem hiding this comment.
Thanks so much for doing this!
efekarakus
approved these changes
Mar 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #2848 . Updated Copilot docs Concepts | Environments page explaining why Copilot places workloads in public subnet. While not changing Copilot's behavior, this lets users know why the default approach was chosen and how they can go about changing it if so desired.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.