fix: respect network replacement configured through manifest#3352
Merged
mergify[bot] merged 9 commits intoaws:mainlinefrom Mar 14, 2022
Merged
Conversation
iamhopaul123
approved these changes
Mar 11, 2022
efekarakus
reviewed
Mar 11, 2022
Comment on lines
+534
to
+535
| // PlacementP converts a string to a `Placement` type and returns its pointer. | ||
| func PlacementP(p string) *Placement { |
Contributor
There was a problem hiding this comment.
What do you think of instead the following approach:
package manifest
// Placement represents VPC subnet placement.
type Placement string
const (
PublicSubnetPlacement Placement = "public"
PrivateSubnetPlacement Placement = "private"
)
efekarakus
approved these changes
Mar 12, 2022
Lou1415926
added
do-not-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #3346 by:
networkfield. The logic preset the network's placement value, which causes the bug that's seen in Environment overrides fornetworkare overwriting base definitions. #3346.constinstead ofvarfor placement types.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.