Skip to content

docs(ja): periodic update#3354

Merged
mergify[bot] merged 40 commits intoaws:mainlinefrom
shingos:ja-docs-periodic-update
Mar 15, 2022
Merged

docs(ja): periodic update#3354
mergify[bot] merged 40 commits intoaws:mainlinefrom
shingos:ja-docs-periodic-update

Conversation

@shingos
Copy link
Copy Markdown
Contributor

@shingos shingos commented Mar 14, 2022

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@shingos shingos requested review from a team, hkford and toricls as code owners March 14, 2022 07:48
@amazon-ecs-cli-v2-pr-manager amazon-ecs-cli-v2-pr-manager requested review from efekarakus and removed request for a team March 14, 2022 07:48
Copy link
Copy Markdown
Contributor

@hkford hkford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @shingos, left a few comments and suggestions!

Comment thread site/content/docs/include/nlb.ja.md Outdated
Comment thread site/content/docs/include/nlb.ja.md Outdated
Comment thread site/content/docs/include/nlb.ja.md Outdated
Comment thread site/content/docs/manifest/rd-web-service.ja.md Outdated
Comment thread site/content/docs/manifest/rd-web-service.ja.md Outdated
Copy link
Copy Markdown
Contributor

@hkford hkford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left minor suggestions 🙏

Comment thread site/content/docs/manifest/rd-web-service.ja.md
Comment thread site/content/docs/manifest/rd-web-service.ja.md Outdated
Copy link
Copy Markdown
Contributor

@hkford hkford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @shingos!

Copy link
Copy Markdown
Contributor

@efekarakus efekarakus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mergify mergify Bot merged commit 3fcdda6 into aws:mainline Mar 15, 2022
hkford pushed a commit that referenced this pull request Mar 30, 2022
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants