feat(templates): render min max config in cfn template#3461
Merged
mergify[bot] merged 10 commits intoaws:mainlinefrom Apr 14, 2022
Merged
feat(templates): render min max config in cfn template#3461mergify[bot] merged 10 commits intoaws:mainlinefrom
mergify[bot] merged 10 commits intoaws:mainlinefrom
Conversation
efekarakus
changed the title
Lou1415926
reviewed
Apr 13, 2022
Lou1415926
reviewed
Apr 13, 2022
Comment on lines
+33
to
+34
| # deployment: # deployment strategy for the "test" environment. | ||
| # rolling: 'recreate' # key is rolling deployment and value is deployment strategy name i.e. either default or recreate. No newline at end of file |
Contributor
There was a problem hiding this comment.
Do we have to update these comments in test manifest data?
Contributor
Author
There was a problem hiding this comment.
Yes we need to as test manifest by default has those lines in it when they create new manifest.
Contributor
There was a problem hiding this comment.
These testdata doesn't test that unfortunately.
They are data consumed by the integration test whose purpose would be to validate the template, not to validate the default manifest.
I think in this case then we can remove all these lines in testdata
Sorry I misread the file path! Thought this was deploy/cloudformation/stack/testdata. This looks good to me!
Lou1415926
approved these changes
Apr 13, 2022
Contributor
Lou1415926
left a comment
Lou1415926
left a comment
There was a problem hiding this comment.
LGTM just a few more nits!
Lou1415926
added
the
do-not-merge
dannyrandall
approved these changes
Apr 13, 2022
Lou1415926
removed
the
do-not-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #3427
With this PR we build the logic to configure the values of MinimumHealthyPercent and MaximumPercent based on the
deploymentparameter in the service manifest