Skip to content

docs: observability for lbws/worker service/backend service#3492

Merged
mergify[bot] merged 17 commits intoaws:mainlinefrom
dannyrandall:docs/observability
May 5, 2022
Merged

docs: observability for lbws/worker service/backend service#3492
mergify[bot] merged 17 commits intoaws:mainlinefrom
dannyrandall:docs/observability

Conversation

@dannyrandall
Copy link
Copy Markdown
Contributor

Docs follow up from: #3481, #3451

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@dannyrandall dannyrandall requested a review from a team as a code owner April 21, 2022 18:26
@dannyrandall dannyrandall requested review from Lou1415926 and removed request for a team April 21, 2022 18:26
Comment thread site/content/docs/include/observability.en.md
@dannyrandall dannyrandall marked this pull request as draft April 22, 2022 16:55
@dannyrandall dannyrandall marked this pull request as ready for review May 3, 2022 23:09
Comment thread site/content/docs/developing/observability.en.md Outdated
Comment thread site/content/docs/include/observability.en.md
Comment thread site/content/docs/developing/observability.en.md Outdated
Copy link
Copy Markdown
Contributor

@efekarakus efekarakus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind testing out with make site-local if you haven't tried it before? just to make sure that the new lines and what not are all rendered nicely.

For example newlines require two spaces " " at the end of the line to render on the site, unlike github flavored markdown

Comment thread site/content/docs/developing/observability.en.md
Comment thread site/content/docs/developing/observability.en.md Outdated
@Lou1415926 Lou1415926 added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label May 4, 2022
@dannyrandall dannyrandall removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label May 4, 2022
Copy link
Copy Markdown
Contributor

@huanjani huanjani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mergify mergify Bot merged commit 1e4dce6 into aws:mainline May 5, 2022
@dannyrandall dannyrandall deleted the docs/observability branch May 5, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants