feat: allow placing workloads in any subnets#3592
Merged
mergify[bot] merged 6 commits intoaws:mainlinefrom May 25, 2022
Merged
Conversation
iamhopaul123
added
the
do-not-merge
iamhopaul123
removed
the
do-not-merge
efekarakus
reviewed
May 24, 2022
efekarakus
approved these changes
May 25, 2022
dannyrandall
approved these changes
May 25, 2022
dannyrandall
added
the
do-not-merge
Lou1415926
reviewed
May 25, 2022
| if err = r.Network.Validate(); err != nil { | ||
| return fmt.Errorf(`validate "network": %w`, err) | ||
| } | ||
| if r.Network.VPC.Placement.PlacementString != nil && |
Contributor
Author
There was a problem hiding this comment.
Yeah we had it before. In the previous PR we thought placing vpc connectors in public subnets work, so we removed this validation.
iamhopaul123
removed
the
do-not-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.