docs: add docs for security group rules for environment's security group#3876
Merged
mergify[bot] merged 10 commits intoaws:mainlinefrom Aug 15, 2022
Merged
docs: add docs for security group rules for environment's security group#3876mergify[bot] merged 10 commits intoaws:mainlinefrom
mergify[bot] merged 10 commits intoaws:mainlinefrom
Conversation
paragbhingre
requested review from
dannyrandall
and removed request for
a team
paragbhingre
changed the title
paragbhingre
changed the title
paragbhingre
changed the title
huanjani
reviewed
Aug 10, 2022
huanjani
reviewed
Aug 10, 2022
huanjani
reviewed
Aug 10, 2022
Lou1415926
reviewed
Aug 11, 2022
| - ip_protocol: tcp | ||
| ports: 80 | ||
| cidr: 0.0.0.0/0 | ||
| ``` |
Contributor
There was a problem hiding this comment.
We probably need to include a section for each of the fields ip_protocol, ports and cidr. For example: https://aws.github.io/copilot-cli/docs/manifest/lb-web-service/#publish-topics-topic
Lou1415926
approved these changes
Aug 12, 2022
Contributor
Lou1415926
left a comment
Lou1415926
left a comment
There was a problem hiding this comment.
lgtm! just some nits. feel free to remove the label when ur ready!
Lou1415926
added
the
do-not-merge
dannyrandall
approved these changes
Aug 15, 2022
rclinard-amzn
approved these changes
Aug 15, 2022
Contributor
rclinard-amzn
left a comment
rclinard-amzn
left a comment
There was a problem hiding this comment.
Great work, looks good to me!
paragbhingre
removed
the
do-not-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #3810
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.