chore: Add Windows Server 2022 Support#3968
Merged
mergify[bot] merged 2 commits intoaws:mainlinefrom Sep 8, 2022
Merged
Conversation
paragbhingre
added
the
do-not-merge
rawahars
reviewed
Aug 31, 2022
rawahars
approved these changes
Aug 31, 2022
paragbhingre
removed
the
do-not-merge
hkford
reviewed
Sep 1, 2022
Contributor
hkford
left a comment
hkford
left a comment
There was a problem hiding this comment.
Thank you for opening pull request!
And thank you for fixing Japanese document as well.
Left a minor comment.
| $ copilot task run --platform-os WINDOWS_SERVER_2019_CORE --platform-arch X86_64 --cpu 1024 --memory 2048 | ||
| ``` | ||
|
|
||
| Windows 2022 タスクを最小のCPUとメモリで実行します。 |
Contributor
There was a problem hiding this comment.
I think it is easy to read if there are spaces between English words and Japanese words like "最小の CPU とメモリ"
Contributor
Author
There was a problem hiding this comment.
Done please let me know if that is what you wanted.
huanjani
reviewed
Sep 1, 2022
| }, | ||
| }, | ||
| "should return windows server core and x86_64 when platform is 'windows/x86_64'": { | ||
| "should return windows server 2019 core and x86_64 when advanced config specifies core": { |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| "should return windows server 2019 core and x86_64 when advanced config specifies core": { | |
| "should return windows server 2019 core and x86_64 when advanced config specifies 2019 core": { |
huanjani
reviewed
Sep 1, 2022
| Arch: template.ArchX86, | ||
| }, | ||
| }, | ||
| "should return windows server 2022 full and x86_64 when advanced config specifies full": { |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| "should return windows server 2022 full and x86_64 when advanced config specifies full": { | |
| "should return windows server 2022 full and x86_64 when advanced config specifies 2022 full": { |
huanjani
reviewed
Sep 1, 2022
| Arch: template.ArchX86, | ||
| }, | ||
| }, | ||
| "should return windows server 2022 core and x86_64 when advanced config specifies core": { |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| "should return windows server 2022 core and x86_64 when advanced config specifies core": { | |
| "should return windows server 2022 core and x86_64 when advanced config specifies 2022 core": { |
huanjani
reviewed
Sep 1, 2022
Contributor
|
Wow, thank you so much for this thorough PR! |
huanjani
changed the title
Adds Windows Server 2022 Support for OS Platform. Signed-off-by: Justin Terry <jlterry@amazon.com>
Codecov Report
@@ Coverage Diff @@
## mainline #3968 +/- ##
===========================================
Coverage ? 68.52%
===========================================
Files ? 248
Lines ? 35048
Branches ? 264
===========================================
Hits ? 24018
Misses ? 9839
Partials ? 1191 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
hkford
approved these changes
Sep 7, 2022
Contributor
hkford
left a comment
hkford
left a comment
There was a problem hiding this comment.
LGTM!Thank you for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Windows Server 2022 Support for OS Platform.
Signed-off-by: Justin Terry jlterry@amazon.com
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.