docs(ja): periodic update for v1.20 and v1.21#3976
Merged
mergify[bot] merged 8 commits intoaws:mainlinefrom Sep 8, 2022
Merged
docs(ja): periodic update for v1.20 and v1.21#3976mergify[bot] merged 8 commits intoaws:mainlinefrom
mergify[bot] merged 8 commits intoaws:mainlinefrom
Conversation
shingos
changed the title
shingos
changed the title
Codecov Report
@@ Coverage Diff @@
## mainline #3976 +/- ##
============================================
- Coverage 68.53% 68.52% -0.01%
============================================
Files 248 248
Lines 35047 35047
Branches 264 264
============================================
- Hits 24019 24017 -2
- Misses 9836 9839 +3
+ Partials 1192 1191 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
hkford
suggested changes
Sep 4, 2022
Contributor
hkford
left a comment
hkford
left a comment
There was a problem hiding this comment.
Thank you for opening this PR.
I left some comment.
Moreover, could you follow conventional commit specification next time? I think the commit title lacks a space after colon.
shingos
changed the title
hkford
suggested changes
Sep 6, 2022
Contributor
hkford
left a comment
hkford
left a comment
There was a problem hiding this comment.
Thank you for updating this PR. I left some comments.
Let's discuss how to translate sentences in this thread.
huanjani
reviewed
Sep 7, 2022
huanjani
reviewed
Sep 7, 2022
huanjani
added
the
do-not-merge
huanjani
approved these changes
Sep 7, 2022
Contributor
huanjani
left a comment
huanjani
left a comment
There was a problem hiding this comment.
Wow! So many additions and improvements! 👏🏼
Just one tiny suggestion to change something that came from the English version (that we need to change on our side); feel free to remove the Do-Not-Merge label when you're ready!
Co-authored-by: Janice Huang <60631893+huanjani@users.noreply.github.com>
Contributor
Author
|
@huanjani Thank you. Now that ready, could you have the labels removed? I could not remove the label. |
hkford
removed
the
do-not-merge
hkford
pushed a commit
that referenced
this pull request
Sep 12, 2022
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.