Skip to content

feat: previously stopped task with the stopped task id#3983

Merged
mergify[bot] merged 4 commits intoaws:mainlinefrom
paragbhingre:addTaskIdToPreviousFeature
Sep 9, 2022
Merged

feat: previously stopped task with the stopped task id#3983
mergify[bot] merged 4 commits intoaws:mainlinefrom
paragbhingre:addTaskIdToPreviousFeature

Conversation

@paragbhingre
Copy link
Copy Markdown
Contributor

@paragbhingre paragbhingre commented Sep 7, 2022

Fixes #3272 and #3961, reverting #3960

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@paragbhingre paragbhingre requested a review from a team as a code owner September 7, 2022 17:02
@paragbhingre paragbhingre requested review from Lou1415926 and removed request for a team September 7, 2022 17:02
Comment thread internal/pkg/cli/svc_logs.go Outdated
Comment thread internal/pkg/cli/svc_logs_test.go
@huanjani huanjani added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Sep 8, 2022
Copy link
Copy Markdown
Contributor

@huanjani huanjani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One nit, then feel free to remove label!

Copy link
Copy Markdown
Contributor

@Lou1415926 Lou1415926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! and +1 to @huanjani about using log. Does this fix #3272 though? Did you mean to link a different issue?

@paragbhingre
Copy link
Copy Markdown
Contributor Author

LGTM! and +1 to @huanjani about using log. Does this fix #3272 though? Did you mean to link a different issue?

We had reverted the changes for the fix #3272 in #3960 right? So this change adds those changes back along with printing task id. Does that make sense?

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #3983 (e1ae307) into mainline (df4dcb9) will increase coverage by 0.04%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##           mainline    #3983      +/-   ##
============================================
+ Coverage     68.53%   68.57%   +0.04%     
============================================
  Files           248      248              
  Lines         35047    35178     +131     
  Branches        264      264              
============================================
+ Hits          24019    24125     +106     
- Misses         9836     9862      +26     
+ Partials       1192     1191       -1     
Impacted Files Coverage Δ
internal/pkg/cli/svc_logs.go 46.05% <50.00%> (+3.76%) ⬆️
...ternal/pkg/deploy/cloudformation/cloudformation.go 72.47% <0.00%> (-0.55%) ⬇️
internal/pkg/task/task.go 100.00% <0.00%> (ø)
...al/pkg/deploy/cloudformation/stack/transformers.go 74.89% <0.00%> (+0.57%) ⬆️
internal/pkg/template/workload.go 44.10% <0.00%> (+6.24%) ⬆️
internal/pkg/manifest/workload_ecs.go 67.83% <0.00%> (+6.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@paragbhingre paragbhingre removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Sep 9, 2022
@mergify mergify Bot merged commit bfda024 into aws:mainline Sep 9, 2022
@paragbhingre paragbhingre deleted the addTaskIdToPreviousFeature branch January 26, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal: logs -p or logs --open

5 participants